Skip to content

Conversation

@kuceb
Copy link
Contributor

@kuceb kuceb commented May 15, 2018

closes #595

@kuceb kuceb changed the title update installing page CLI Caching May 15, 2018
@kuceb kuceb requested a review from jennifer-shehane May 16, 2018 02:40
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am finding the difference between 'Binary Cache Directory' and 'Cypress Binary Folder' to be a bit difficult to distinguish.

  1. Doesn't directory = folder?? Why are they called different things.
  2. I believe the difference is that the CYPRESS_BINARY_CACHE is the location that Cypress will download the binary cache to and the CYPRESS_BINARY_FOLDER is the directory that Cypress will look into to download the cache from. If that is the case - can you make these points clearer? One is where the cache will be saved / the other is where the cache will be accessed.

@jennifer-shehane jennifer-shehane changed the base branch from develop to issue-461 May 18, 2018 17:57
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Thanks @bkucera! 👍

@jennifer-shehane jennifer-shehane merged commit 2637e8f into issue-461 May 21, 2018
brian-mann pushed a commit that referenced this pull request May 29, 2018
* update Dashboard service screenshots / content

- update some of the screenshots to reflect the new tabs
- change some of the wording about where you can access screenshots and
videos

* Update description and examples for '--spec' arg in command log

* Began writing changelog for 3.0.0

* update roadmap to remove 'running multiple specs'

- added some other issues to future roadmap

* Update docs to reflect new example seeded files

* Add more merged PRs to the changelog

* added more 3.0 fixes to changelog

- updated ‘close’ event specs to new changes.

* add newest commits to changelog

* Add more merged PRs to changelog

* package.lock update

* Added a couple merged prs to changelog

* update package.lock

* Add doc for cy.task() (#445)

* add doc for cy.task()

* fix hexo version

* update task doc to latest api

* add task event references

* add references for cy.task recipe

* remove 'comments: false' from each files - it does nothing.

close #141

* Added Cypress binary feature to changelog - removed from roadmap

* Begin editing cy.task() doc

* Normalize use of Node across docs to be capitalized and not in code brackets

* Edit cy.task

* Update viewport arguments with changes to width and height bounds (#456)

* add screenshot content to changelog

- update command line to show accepting multiple specs in —spec flag.

* Add screenshot configuration doc (#480)

* package-lock changes

* fix invalid css

* add doc for Cypress.Screenshot api

* update screenshot doc with latest capture values

* update screenshot docs

* update screenshot docs with latest api

* add screenshot content to changelog

- update command line to show accepting multiple specs in —spec flag.

* store npm-debug logs in artifacts

* npm logs

* fix package-lock.json weirdness - needed to delete node_modules locally.

* Fix bug with changelog not displaying completely

* Clean up screenshot doc for release

* Edit screenshot api file

* Update screenshot doc to be more specific after clarification.

* Added an example of seeding a db to cy.task

* added newest chrome flag to changelog

* package-lock changes

* fix time out grammar

* update screenshot docs to latest api

* fullpage -> fullPage

* CLI Caching  (#596)

* update installing page
* update docs with new env vars

* woops - forgot to save package-lock

* Added newly fixed issues to changelog

* Clean up some of new docs

* package-lock

* Add 2 new issues to changelog

* Update uses of 'headless' to ‘during cypress run’

- Update uses of ‘GUI’ to ‘Test Runner’ or ‘interactive’
- some h3 header conversions

* Update answer in FAQ on 'how to run group of specs' to match new spec arg

* Update launching browsers to say we now disable device discovery notifications

* Rename config trashAssetsBeforeHeadlessRuns to trashAssetsBeforeRuns

* Fixes to inaccurate docs

- remove mention of cy.screenshot yielding ‘null’
- add cy.screenshot as example of dual command
- add more h3 conversions
- add cy.task to more references in other docs

* Update dashboard content/screenshots

- put screenshots of new uis

* update changelog to specify that video filenames are only changed locally

* SelectorPlayground -> Screenshot in screenshot api doc

* document screenshot callbacks

* add missing 'is'

* Add missing 'is'

* clean up some headers/content for screenshots
@kuceb kuceb mentioned this pull request May 30, 2018
@jennifer-shehane jennifer-shehane deleted the issue-595 branch September 18, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants